anishshri-db commented on code in PR #47730:
URL: https://github.com/apache/spark/pull/47730#discussion_r1718008265
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -889,11 +892,17 @@ object RocksDBFileManagerMetrics {
case class RocksDBCheckpointMetadata(
sstFiles: Seq[RocksDBSstFile],
logFiles: Seq[RocksDBLogFile],
- numKeys: Long) {
+ numKeys: Long,
+ columnFamilyMapping: Option[Map[String, Short]] = None,
+ maxColumnFamilyId: Option[Short] = None) {
+
+ require(columnFamilyMapping.isDefined == maxColumnFamilyId.isDefined,
+ "columnFamilyMapping and maxColumnFamilyId must either both be defined or
both be None")
+
import RocksDBCheckpointMetadata._
def json: String = {
- // We turn this field into a null to avoid write a empty logFiles field in
the json.
+ // We turn this field into a null to avoid write an empty logFiles field
in the json.
Review Comment:
nit: `writing an empty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
