jingz-db commented on code in PR #47730:
URL: https://github.com/apache/spark/pull/47730#discussion_r1718801474
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -1026,15 +1026,14 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
}
}
- // TODO SPARK-48796 after restart state id will not be the same
- ignore(s"get, put, iterator, commit, load with multiple column families") {
+ test(s"get, put, iterator, commit, load with multiple column families") {
Review Comment:
Nits:
- We could probably change the PR title name a bit as we are now not loading
col family Id from State schema for VCF, instead we do that in RocksDB metadata
file.
- Could we enable this test in `TransformWithStateSuite` to see if it
passes:
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala#L654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
