anishshri-db commented on code in PR #47730:
URL: https://github.com/apache/spark/pull/47730#discussion_r1718010262
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -581,10 +592,11 @@ private[sql] class RocksDBStateStoreProvider
Option[Short] = {
verifyColFamilyCreationOrDeletion("create_col_family", colFamilyName,
isInternal)
if (!checkColFamilyExists(colFamilyName)) {
- val newColumnFamilyId = colFamilyId.incrementAndGet().toShort
+ val newColumnFamilyId = (maxColumnFamilyId + 1).toShort
Review Comment:
Lets add a note saying that this id generation is deterministic across
batches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
