HyukjinKwon commented on code in PR #47835:
URL: https://github.com/apache/spark/pull/47835#discussion_r1725971203
##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -279,15 +282,6 @@ def test_drop_duplicates(self):
messageParameters={"arg_name": "subset", "arg_type": "NoneType"},
)
- with self.assertRaises(PySparkTypeError) as pe:
- df.dropDuplicates(None).show()
-
- self.check_error(
- exception=pe.exception,
- errorClass="NOT_STR",
- messageParameters={"arg_name": "subset", "arg_type": "NoneType"},
- )
-
Review Comment:
Let's add it to the migration guide
`python/docs/source/migration_guide/pyspark_upgrade.rst`. Also you can leverage
`_NoValue` instance to distinguish `None` from not setting a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
