allisonwang-db commented on PR #47835:
URL: https://github.com/apache/spark/pull/47835#issuecomment-2311082085
My general comment here is that we should be opinionated and only have one
way to perform certain operations. After this change, users now have two
identical ways to drop duplicates:
1. `dropDuplicates("c1", "c2")`
2. `dropDuplicates(["c1", "c2"])`
Which one should users choose?
P.S. Pandas / Pandas on Spark uses the `subset=["c1", "c2"]` pattern (see:
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.drop_duplicates.html
and
https://spark.apache.org/docs/latest/api/python/reference/pyspark.pandas/api/pyspark.pandas.DataFrame.drop_duplicates.html).
It could be confusing to make the PySpark API different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
