WweiL commented on code in PR #47835:
URL: https://github.com/apache/spark/pull/47835#discussion_r1727565269
##########
python/pyspark/sql/dataframe.py:
##########
@@ -4570,7 +4570,9 @@ def subtract(self, other: "DataFrame") -> "DataFrame":
...
@dispatch_df_method
- def dropDuplicates(self, *subset: Union[str, List[str]]) -> "DataFrame":
+ def dropDuplicates(
+ self, subset: Optional[Union[str, List[str], _NoValueType]] =
_NoValue, *subset_varargs: str
+ ) -> "DataFrame":
Review Comment:
ah sure let me add them
##########
python/pyspark/sql/dataframe.py:
##########
@@ -4570,7 +4570,9 @@ def subtract(self, other: "DataFrame") -> "DataFrame":
...
@dispatch_df_method
- def dropDuplicates(self, *subset: Union[str, List[str]]) -> "DataFrame":
+ def dropDuplicates(
+ self, subset: Optional[Union[str, List[str], _NoValueType]] =
_NoValue, *subset_varargs: str
+ ) -> "DataFrame":
Review Comment:
ah sure let me add them, thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
