nicklamiller commented on code in PR #47493:
URL: https://github.com/apache/spark/pull/47493#discussion_r1728152749
##########
python/pyspark/sql/dataframe.py:
##########
@@ -30,6 +30,7 @@
overload,
TYPE_CHECKING,
)
+from typing_extensions import Concatenate, ParamSpec
Review Comment:
Thanks for taking the time to review!
I've moved this import to its corresponding `_typing.pyi` file, as is done
elsewhere in Spark when using objects that come from `typing_extensions`:
https://github.com/apache/spark/blob/97e0a88b1d04a8e33206e5cb8384878ca4cdfc5a/python/pyspark/mllib/stat/_statistics.py#L30-L31
https://github.com/apache/spark/blob/97e0a88b1d04a8e33206e5cb8384878ca4cdfc5a/python/pyspark/mllib/_typing.pyi#L31
https://github.com/apache/spark/blob/97e0a88b1d04a8e33206e5cb8384878ca4cdfc5a/python/pyspark/mllib/_typing.pyi#L21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
