nicklamiller commented on code in PR #47493: URL: https://github.com/apache/spark/pull/47493#discussion_r1728156889
########## python/pyspark/sql/_typing.pyi: ########## @@ -37,6 +37,10 @@ from pyspark.profiler import CodeMapDict import pyspark.sql.types from pyspark.sql.column import Column +__all__ = ["Concatenate"] Review Comment: This is to suppress the mypy error: ```sh pyspark/sql/dataframe.py:53: error: Module "pyspark.sql._typing" does not explicitly export attribute "Concatenate" [attr-defined] ``` `Concatenate` is now being imported into `python/pyspark/sql/dataframe.py` from its corresponding `_typing.pyi` file, so it appears it now needs to be explicitly exported from `_typing.pyi`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
