HyukjinKwon commented on code in PR #47493:
URL: https://github.com/apache/spark/pull/47493#discussion_r1728174526


##########
python/pyspark/sql/_typing.pyi:
##########
@@ -26,7 +26,7 @@ from typing import (
     TypeVar,
     Union,
 )
-from typing_extensions import Literal, Protocol
+from typing_extensions import Concatenate, Literal, ParamSpec, Protocol

Review Comment:
   `Concatenate` is from Python 3.10 
(https://docs.python.org/3/library/typing.html#typing.Concatenate) and PySpark 
supports Python 3.9 and above 
(https://github.com/apache/spark/blob/master/python/packaging/classic/setup.py#L372)
 so it won't work. Can we work around?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to