Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/6538#discussion_r31489051
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -82,6 +82,19 @@ object MLUtils {
val value = indexAndValue(1).toDouble
(index, value)
}.unzip
+
+ // check if indices is one-based and in ascending order
--- End diff --
indices(0) is compared with -1 in current implementation.
Your way looks more compact. The only concern is if it will create many
groupIterators. I'll run some benchmark and get back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
