Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/6538#discussion_r31505632
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -82,6 +82,19 @@ object MLUtils {
val value = indexAndValue(1).toDouble
(index, value)
}.unzip
+
+ // check if indices is one-based and in ascending order
--- End diff --
1. I will use `require` for the check.
2. indices is -> indices are
And since there's a `-1` in line 81, it's acceptable to have indices(0) ==
0 here. (changed to zero-based).
The first ut has covered the check for zero-based LIBSVM file.
Let me know if I should change more. Thanks a lot for the careful check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
