prathit06 commented on PR #48079: URL: https://github.com/apache/spark/pull/48079#issuecomment-2344273372
> Thank you for making a PR, @prathit06 . > > The proposed pattern `options.labels` is inconsistent from Apache Spark's way; `spark.kubernetes.driver.label.something=true` and `spark.kubernetes.executor.label.something=true`. Please follow the standard way. Thanks for the review @dongjoon-hyun , will work on the provided suggestion & update here once the PR is ready for review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
