dongjoon-hyun commented on code in PR #48079:
URL: https://github.com/apache/spark/pull/48079#discussion_r1756996927
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStepSuite.scala:
##########
@@ -131,6 +131,78 @@ class MountVolumesFeatureStepSuite extends SparkFunSuite {
assert(pvcClaim.getClaimName.endsWith("-driver-pvc-0"))
}
+ test("Create and mounts persistentVolumeClaims in driver with labels") {
+ val volumeConf = KubernetesVolumeSpec(
+ "testVolume",
+ "/tmp",
+ "",
+ true,
+ KubernetesPVCVolumeConf(MountVolumesFeatureStep.PVC_ON_DEMAND,
+ labels = Map("foo" -> "bar", "env" -> "test"),
Review Comment:
Although this is supported by language, we recommend to keep the parameter
order. `labels` is the last parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
