dongjoon-hyun commented on code in PR #48079: URL: https://github.com/apache/spark/pull/48079#discussion_r1756986862
########## docs/running-on-kubernetes.md: ########## @@ -1182,6 +1182,15 @@ See the [configuration page](configuration.html) for information on Spark config </td> <td>2.4.0</td> </tr> +<tr> + <td><code>spark.kubernetes.driver.volumes.label.[VolumeType].[VolumeName].[LabelName]</code></td> Review Comment: Well this looks wrong to me because `label` could be interpreted as `[VolumeType]` in the existing pattern. Can we follow `options` location like you did previously? I expected the following specifically ``` spark.kubernetes.driver.volumes.[VolumeType].[VolumeName].label.[LabelName] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
