manuzhang commented on code in PR #47724:
URL: https://github.com/apache/spark/pull/47724#discussion_r1766313026
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -579,6 +581,18 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
}
object ResolvedV1Identifier {
+ def unapply(resolved: LogicalPlan): Option[TableIdentifier] = resolved
match {
+ case ResolvedIdentifier(catalog, ident) if supportsV1Command(catalog) =>
Review Comment:
> Does Iceberg catalog extend DelegatingCatalogExtension?
Nope.
> We do want to use v2 commands for custom catalogs that do not extend
DelegatingCatalogExtension
Even so, is it the right time to introduce such a behavior change in a bug
fix release?
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -579,6 +581,18 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
}
object ResolvedV1Identifier {
+ def unapply(resolved: LogicalPlan): Option[TableIdentifier] = resolved
match {
+ case ResolvedIdentifier(catalog, ident) if supportsV1Command(catalog) =>
Review Comment:
> Does Iceberg catalog extend DelegatingCatalogExtension?
Nope.
> We do want to use v2 commands for custom catalogs that do not extend
DelegatingCatalogExtension
Even so, is it the right time to introduce such a behavior change in a bug
fix release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
