cloud-fan commented on code in PR #47724:
URL: https://github.com/apache/spark/pull/47724#discussion_r1766331798
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -579,6 +581,18 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
}
object ResolvedV1Identifier {
+ def unapply(resolved: LogicalPlan): Option[TableIdentifier] = resolved
match {
+ case ResolvedIdentifier(catalog, ident) if supportsV1Command(catalog) =>
Review Comment:
We can consider it as a bug. People implementing DS V2 catalog APIs expect
to see v2 commands to customize the table behaviors. And there is a backdoor:
`DelegatingCatalogExtension`.
For iceberg, it should be easy to work around it by extending
`DelegatingCatalogExtension`? Iceberg catalog can still keep all its methods
unchanged, don't use the `delegate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
