manuzhang commented on code in PR #47724:
URL: https://github.com/apache/spark/pull/47724#discussion_r1767894234
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -579,6 +581,18 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
}
object ResolvedV1Identifier {
+ def unapply(resolved: LogicalPlan): Option[TableIdentifier] = resolved
match {
+ case ResolvedIdentifier(catalog, ident) if supportsV1Command(catalog) =>
Review Comment:
Iceberg's
[SparkSessionCatalog](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java)
already extends a base class. There's no easy way to extend
`DelegatingCatalogExtension` without a major refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
