agubichev commented on code in PR #48145:
URL: https://github.com/apache/spark/pull/48145#discussion_r1768902792
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1046,10 +1049,12 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
case Filter(_, a: Aggregate) =>
checkAggregateInScalarSubquery(outerAttrs, query, a)
case p: LogicalPlan if p.maxRows.exists(_ <= 1) => // Ok
case other =>
- expr.failAnalysis(
- errorClass = "UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY." +
- "MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY",
- messageParameters = Map.empty)
+ if
(!SQLConf.get.getConf(SQLConf.SCALAR_SUBQUERY_USE_SINGLE_JOIN)) {
+ expr.failAnalysis(
Review Comment:
The second check (in lines 1060-1080 of the current file) checks the places
where the scalar subquery is allowed (e.g., it can occur in the project or
filter but not in the join predicate).
The first check ensures the property of the subquery itself (1 column and at
most 1 row)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
