agubichev commented on code in PR #48145:
URL: https://github.com/apache/spark/pull/48145#discussion_r1768975280
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -269,8 +269,13 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
}
+ def canMerge(joinType: JoinType): Boolean = joinType match {
+ case LeftSingle => false
Review Comment:
in principle, it can do it, but I did not implement it.
as we only need single joins for correlated scalar subqueries with non-equal
predicate, the SMJ are unlikely to be useful there anyways.
(for equi-predicates like
'col = outer(col) .. group by col', we reason that the query returns at most
1 row and don't need the single join).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
