agubichev commented on code in PR #48145:
URL: https://github.com/apache/spark/pull/48145#discussion_r1769035823
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##########
@@ -456,6 +456,33 @@ object PullupCorrelatedPredicates extends
Rule[LogicalPlan] with PredicateHelper
(newPlan, newCond)
}
+ // Returns true if 'query' is guaranteed to return at most 1 row.
+ private def guaranteedToReturnOneRow(query: LogicalPlan): Boolean = {
Review Comment:
done, but the amount of savings is not spectacular, because in CheckAnalysis
there is also a "legacy" path (that results in incorrect results) where the
check is significantly weaker.
Once the single join is rolled out, we will just remove all extra checks
from CheckAnalysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
