hvanhovell commented on code in PR #48320: URL: https://github.com/apache/spark/pull/48320#discussion_r1792401918
########## sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala: ########## @@ -106,7 +106,14 @@ private[sql] class SessionState( // when connecting to ThriftServer. lazy val streamingQueryManager: StreamingQueryManager = streamingQueryManagerBuilder() - lazy val artifactManager: ArtifactManager = artifactManagerBuilder() + private[sql] var _artifactManager: Option[ArtifactManager] = None Review Comment: I am not sure I follow. Now you have mutable state that makes reasoning about the resulting artifact manager harder than it should be. You can make the `artifactManagerBuilder ` return a constant right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
