hvanhovell commented on code in PR #48320:
URL: https://github.com/apache/spark/pull/48320#discussion_r1803431953


##########
sql/core/src/main/scala/org/apache/spark/sql/artifact/ArtifactManager.scala:
##########
@@ -279,6 +296,49 @@ class ArtifactManager(session: SparkSession) extends 
Logging {
     loader
   }
 
+  private[sql] def clone(newSession: SparkSession): ArtifactManager = {
+    val sparkContext = session.sparkContext
+    sparkContext.synchronized {
+      val newArtifactManager = new ArtifactManager(newSession)
+      if (artifactPath.toFile.exists()) {
+        FileUtils.copyDirectory(artifactPath.toFile, 
newArtifactManager.artifactPath.toFile)
+      }
+      val blockManager = sparkContext.env.blockManager
+      val newBlockIds = cachedBlockIdList.asScala.map { blockId =>
+        val newBlockId = blockId.copy(sessionUUID = newSession.sessionUUID)
+        copyBlock(blockId, newBlockId, blockManager)
+      }
+
+      // Re-register resources to SparkContext

Review Comment:
   Does this copy or just register? If it does the latter, we could also 
consider creating an explicit method in SparkContext for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to