xupefei commented on code in PR #48320:
URL: https://github.com/apache/spark/pull/48320#discussion_r1803443057
##########
sql/core/src/main/scala/org/apache/spark/sql/artifact/ArtifactManager.scala:
##########
@@ -279,6 +296,49 @@ class ArtifactManager(session: SparkSession) extends
Logging {
loader
}
+ private[sql] def clone(newSession: SparkSession): ArtifactManager = {
+ val sparkContext = session.sparkContext
+ sparkContext.synchronized {
Review Comment:
This lock is to avoid concurrently calling `sparkContext.addJar` because
it's not thread-safe.
I think it's possible to reduce the lock scope to the "re-register" part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
