yaooqinn commented on code in PR #48395:
URL: https://github.com/apache/spark/pull/48395#discussion_r1794703510
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -2688,7 +2688,7 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
val df = sql("SELECT SUM(2147483647 + DEPT) FROM h2.test.employee")
checkAggregateRemoved(df, ansiMode)
val expectedPlanFragment = if (ansiMode) {
- "PushedAggregates: [SUM(2147483647 + DEPT)], " +
+ "PushedAggregates: [SUM(DEPT + 2147483647)], " +
Review Comment:
This test changes as the reorder rule is applied when contains only one
foldable expression
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -2688,7 +2688,7 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
val df = sql("SELECT SUM(2147483647 + DEPT) FROM h2.test.employee")
checkAggregateRemoved(df, ansiMode)
val expectedPlanFragment = if (ansiMode) {
- "PushedAggregates: [SUM(2147483647 + DEPT)], " +
+ "PushedAggregates: [SUM(DEPT + 2147483647)], " +
Review Comment:
This test changes as the reorder rule is applied when containing only one
foldable expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
