cloud-fan commented on code in PR #48395:
URL: https://github.com/apache/spark/pull/48395#discussion_r1796426171
##########
sql/core/src/test/resources/sql-tests/analyzer-results/null-handling.sql.out:
##########
@@ -69,6 +69,24 @@ Project [a#x, (b#x + c#x) AS (b + c)#x]
+- Relation spark_catalog.default.t1[a#x,b#x,c#x] parquet
+-- !query
+select b + 0 from t1 where a = 5
Review Comment:
I think we should test `b * 0`, where the optimization should be skipped to
respect the NULL semantic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
