cloud-fan commented on code in PR #48395:
URL: https://github.com/apache/spark/pull/48395#discussion_r1796425812
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReorderAssociativeOperatorSuite.scala:
##########
@@ -74,4 +74,33 @@ class ReorderAssociativeOperatorSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
+
+ test("SPARK-49915: Handle zero and one in associative operators") {
+ val originalQuery =
+ testRelation.select(
+ $"a" + 0,
+ Literal(-3) + $"a" + 3,
+ $"b" * 0 * 1 * 2 * 3,
Review Comment:
can we test non-nullable `b` multiple 0?
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReorderAssociativeOperatorSuite.scala:
##########
@@ -74,4 +74,33 @@ class ReorderAssociativeOperatorSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
+
+ test("SPARK-49915: Handle zero and one in associative operators") {
+ val originalQuery =
+ testRelation.select(
+ $"a" + 0,
+ Literal(-3) + $"a" + 3,
+ $"b" * 0 * 1 * 2 * 3,
Review Comment:
can we test non-nullable `b` multiply 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
