jovanpavl-db commented on code in PR #48386:
URL: https://github.com/apache/spark/pull/48386#discussion_r1799051807


##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########


Review Comment:
   For these specific expressions it's tricky - as input type the accepts 
string cast to bigInt so input type check was  avoided (was even before adding 
trim collation).
   
![image](https://github.com/user-attachments/assets/9fe05dad-b347-45b5-9566-dbeeb6215360)
   
   



##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########


Review Comment:
   For this specific expressions it's tricky - as input type the accepts string 
cast to bigInt so input type check was  avoided (was even before adding trim 
collation).
   
![image](https://github.com/user-attachments/assets/9fe05dad-b347-45b5-9566-dbeeb6215360)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to