uros-db commented on code in PR #48386:
URL: https://github.com/apache/spark/pull/48386#discussion_r1798984808
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -41,14 +41,11 @@ class StringType private (val collationId: Int) extends
AtomicType with Serializ
private[sql] def supportsBinaryEquality: Boolean =
CollationFactory.fetchCollation(collationId).supportsBinaryEquality
- private[sql] def supportsLowercaseEquality: Boolean =
- CollationFactory.fetchCollation(collationId).supportsLowercaseEquality
Review Comment:
maybe not at the moment, but I recommend that we keep it for private SQL
datatype API completeness
let's not remove it for now, especially given that this change doesn't have
anything to do with this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
