uros-db commented on code in PR #48386: URL: https://github.com/apache/spark/pull/48386#discussion_r1799010841
########## sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala: ########## Review Comment: here the number of tests is fine, since we don't want to explode the e2e sql tests just one question - why did you add tests for Bin/Hex, but not for other expressions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
