uros-db commented on code in PR #48521:
URL: https://github.com/apache/spark/pull/48521#discussion_r1806379499
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
Review Comment:
I think it would be useful to add a brief comment explaining "unawareness"
with respect to trimming sensitivity for the remaining expressions implemented
as part of `CollationSupport`
for example:
```
public static class Upper {
public static UTF8String exec(final UTF8String v, final int collationId,
boolean useICU) {
CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
// Space trimming does not affect the output of this expression.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
