uros-db commented on code in PR #48521:
URL: https://github.com/apache/spark/pull/48521#discussion_r1806399384
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -295,17 +299,15 @@ public static UTF8String execICU(final UTF8String v,
final int collationId) {
public static class FindInSet {
public static int exec(final UTF8String word, final UTF8String set, final
int collationId) {
Review Comment:
a comment would be useful for developers, explaining that the trimming
sensitivity is taken into account "under the hood" because the collation-aware
`FindInSet` implementation relies on the collator's comparator function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
