uros-db commented on code in PR #48521:
URL: https://github.com/apache/spark/pull/48521#discussion_r1806390814
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -46,14 +49,11 @@ public static UTF8String[] exec(final UTF8String s, final
UTF8String d, final in
}
}
public static String genCode(final String s, final String d, final int
collationId) {
- CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
String expr = "CollationSupport.StringSplitSQL.exec";
- if (collation.isUtf8BinaryType) {
+ if (CollationFactory.UTF8_BINARY_COLLATION_ID == collationId) {
Review Comment:
```suggestion
if (collationId == CollationFactory.UTF8_BINARY_COLLATION_ID) {
```
(or update the others - pick according to your preference, but let's keep it
consistent across the file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
