vladanvasi-db commented on code in PR #48737:
URL: https://github.com/apache/spark/pull/48737#discussion_r1829400694
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -1123,6 +1181,8 @@ public CollationIdentifier identifier() {
public static final List<String> SUPPORTED_PROVIDERS =
List.of(PROVIDER_SPARK, PROVIDER_ICU);
public static final String COLLATION_PAD_ATTRIBUTE = "NO_PAD";
+ public static final int DEFAULT_COLLATION_ID =
Review Comment:
Yes, we can, in fact, I changed the logic ini all places of code that
compares `collationId` directly. I think this single case will not be a problem
since the problematic places in the code are the ones that compare
`collationId` directly. I changed those since we can compare the `StringType`
directly without accessing its `collationId`. So, I do not think that this one
alone will be a problem, but rather comparisons of `collationId` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
