cloud-fan commented on code in PR #48737:
URL: https://github.com/apache/spark/pull/48737#discussion_r1831274197
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -83,9 +83,18 @@ class StringType private (val collationId: Int) extends
AtomicType with Serializ
override def jsonValue: JValue = JString("string")
override def equals(obj: Any): Boolean =
Review Comment:
it will be very tricky if we overwrite the low-level `equals` and `hashCode`
to treat the default collation the same as utf8. We should leave the Java
object equality as it is, and only treat then the same when we only care about
semantic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
