vladanvasi-db commented on code in PR #48737:
URL: https://github.com/apache/spark/pull/48737#discussion_r1829748183
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -394,7 +395,11 @@ private static Collation fetchCollation(int collationId) {
// instance.
assert (collationId >= 0 && getDefinitionOrigin(collationId)
== DefinitionOrigin.PREDEFINED);
- if (collationId == UTF8_BINARY_COLLATION_ID) {
Review Comment:
I agree, but a `StringType` can have this `collationId` even if the
collation is not explicit `UTF8_BINARY`, but also when the collation is
implicitly `UTF8_BINARY` or even default `UTF8_BINARY`. Since this is the case,
we may want to proceed with different naming? @srielau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
