dejankrak-db commented on code in PR #48795:
URL: https://github.com/apache/spark/pull/48795#discussion_r1833112078
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -1605,6 +1605,227 @@ class SqlScriptingParserSuite extends SparkFunSuite
with SQLHelper {
assert(nestedLoopStmt.body.collection(1).asInstanceOf[IterateStatement].label
== "lbl")
}
+ test("unique label names: nested begin-end blocks") {
Review Comment:
Consider perhaps also adding a positive unit test where one label name is a
substring of the other one (e.g. lbl_1 and lbl_11), to check that this would
not fail (this would expose bug if only first N characters up to the shorter
label name length were considered as part of uniqueness check)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
