miland-db commented on code in PR #48795:
URL: https://github.com/apache/spark/pull/48795#discussion_r1834265053
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala:
##########
@@ -134,3 +139,87 @@ object ParserUtils extends SparkParserUtils {
sb.toString()
}
}
+
+object LabelUtils {
Review Comment:
@cloud-fan is `AstBuilder` instantiated every time when parser is invoked?
Is it safe to keep some state inside `AstBuilder` class?
For `LabelUtils` for now is it enough to make `seenLabels` ThreadLocal? Can
single parsing invocation be done from different threads, like threadpool with
different threads that get appointed to do part of the parsing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
