MaxGekk commented on code in PR #48795:
URL: https://github.com/apache/spark/pull/48795#discussion_r1833275615


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -1198,6 +1198,12 @@
     ],
     "sqlState" : "23505"
   },
+  "DUPLICATE_LABEL" : {
+    "message" : [
+      "Label <label> already exists."

Review Comment:
   ```suggestion
         "The label <label> already exists. Choose another name or rename the 
existing label."
   ```



##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -1198,6 +1198,12 @@
     ],
     "sqlState" : "23505"
   },
+  "DUPLICATE_LABEL" : {

Review Comment:
   There are a few `_EXISTS` conditions already (`FIELD_ALREADY_EXISTS`, 
`INDEX_ALREADY_EXISTS`, `LOCATION_ALREADY_EXISTS`, `PATH_ALREADY_EXISTS`) , and 
let's follow naming convention in `error-conditions.json`, and also make it 
consisitent with the error text:
   ```suggestion
     "LABEL_ALREADY_EXISTS" : {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to