anishshri-db commented on code in PR #48401:
URL: https://github.com/apache/spark/pull/48401#discussion_r1839007979
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -492,15 +498,16 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
}
}
- testWithColumnFamilies("rocksdb range scan multiple non-contiguous ordering
columns",
- TestWithBothChangelogCheckpointingEnabledAndDisabled ) {
colFamiliesEnabled =>
+ testWithColumnFamiliesAndEncodingTypes(
+ "rocksdb range scan multiple non-contiguous ordering columns",
+ TestWithBothChangelogCheckpointingEnabledAndDisabled ) {
(colFamiliesEnabled, encodingType) =>
val testSchema: StructType = StructType(
Seq(
- StructField("ordering-1", LongType, false),
+ StructField("ordering1", LongType, false),
StructField("key2", StringType, false),
- StructField("ordering-2", IntegerType, false),
Review Comment:
can we add a test to verify the behavior if `-` is used within the state var
names since its not supported in Avro ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
