ericm-db commented on code in PR #48401:
URL: https://github.com/apache/spark/pull/48401#discussion_r1852599128
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -492,15 +495,16 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
}
}
- testWithColumnFamilies("rocksdb range scan multiple non-contiguous ordering
columns",
+ testWithColumnFamiliesAndEncodingTypes("rocksdb range scan multiple " +
+ "non-contiguous ordering columns",
TestWithBothChangelogCheckpointingEnabledAndDisabled ) {
colFamiliesEnabled =>
val testSchema: StructType = StructType(
Seq(
- StructField("ordering-1", LongType, false),
Review Comment:
Avro would just throw an error, saying that there are invalid characters in
the field name
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -492,15 +495,16 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
}
}
- testWithColumnFamilies("rocksdb range scan multiple non-contiguous ordering
columns",
+ testWithColumnFamiliesAndEncodingTypes("rocksdb range scan multiple " +
+ "non-contiguous ordering columns",
TestWithBothChangelogCheckpointingEnabledAndDisabled ) {
colFamiliesEnabled =>
val testSchema: StructType = StructType(
Seq(
- StructField("ordering-1", LongType, false),
Review Comment:
Avro code would just throw an error, saying that there are invalid
characters in the field name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
