ericm-db commented on code in PR #48401: URL: https://github.com/apache/spark/pull/48401#discussion_r1852601247
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ########## @@ -58,7 +58,7 @@ class RocksDBStateStoreSuite extends StateStoreSuiteBase[RocksDBStateStoreProvid import StateStoreTestsHelper._ - testWithColumnFamilies(s"version encoding", + testWithColumnFamiliesAndEncodingTypes(s"version encoding", Review Comment: > Any reason we just didn't extend the suites with a different SQLConf to test out the different encoding type? I feel that would remove a ton of code changes as well Yeah it would, but not all of these apply to Avro which is an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
