cloud-fan commented on code in PR #48773:
URL: https://github.com/apache/spark/pull/48773#discussion_r1841533685
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala:
##########
@@ -568,17 +572,28 @@ case class MakeYMInterval(years: Expression, months:
Expression)
override def dataType: DataType = YearMonthIntervalType()
override def nullSafeEval(year: Any, month: Any): Any = {
- Math.toIntExact(Math.addExact(month.asInstanceOf[Number].longValue(),
- Math.multiplyExact(year.asInstanceOf[Number].longValue(),
MONTHS_PER_YEAR)))
+ try {
+ Math.toIntExact(
+ Math.addExact(month.asInstanceOf[Int],
+ Math.multiplyExact(year.asInstanceOf[Int], MONTHS_PER_YEAR)))
+ } catch {
Review Comment:
shall we add `IntervalUtils.makeYearMonthInterval` so that we duplicate less
code between interpreted and codegen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
