cloud-fan commented on code in PR #48773:
URL: https://github.com/apache/spark/pull/48773#discussion_r1841929959
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala:
##########
@@ -568,17 +572,28 @@ case class MakeYMInterval(years: Expression, months:
Expression)
override def dataType: DataType = YearMonthIntervalType()
override def nullSafeEval(year: Any, month: Any): Any = {
- Math.toIntExact(Math.addExact(month.asInstanceOf[Number].longValue(),
- Math.multiplyExact(year.asInstanceOf[Number].longValue(),
MONTHS_PER_YEAR)))
+ try {
+ Math.toIntExact(
+ Math.addExact(month.asInstanceOf[Int],
+ Math.multiplyExact(year.asInstanceOf[Int], MONTHS_PER_YEAR)))
+ } catch {
Review Comment:
there is already `makeDayTimeInterval` and we can just follow it. Can you
try it again and create a PR? We can help to check the code together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
