cloud-fan commented on code in PR #48883:
URL: https://github.com/apache/spark/pull/48883#discussion_r1848433259
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -30,7 +30,9 @@ import org.apache.spark.sql.catalyst.util.CollationFactory
* The id of collation for this StringType.
*/
@Stable
-class StringType private (val collationId: Int) extends AtomicType with
Serializable {
+class StringType private[spark] (val collationId: Int, val maxLength:
Option[Int] = None)
Review Comment:
why do we need to have the length info in the base `StringType`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
