mihailom-db commented on code in PR #48883:
URL: https://github.com/apache/spark/pull/48883#discussion_r1863191446
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/common/DataTypeProtoConverter.scala:
##########
@@ -197,6 +187,16 @@ object DataTypeProtoConverter {
.setVarChar(proto.DataType.VarChar.newBuilder().setLength(length).build())
.build()
+ case s: StringType =>
+ proto.DataType
+ .newBuilder()
+ .setString(
+ proto.DataType.String
+ .newBuilder()
+
.setCollation(CollationFactory.fetchCollation(s.collationId).collationName)
+ .build())
+ .build()
+
Review Comment:
Can you add comment above why we are moving this. Just something that string
has to come after char/varchar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
