mihailom-db commented on code in PR #48883:
URL: https://github.com/apache/spark/pull/48883#discussion_r1863197645
##########
sql/api/src/main/scala/org/apache/spark/sql/types/DataType.scala:
##########
@@ -458,7 +458,7 @@ object DataType {
private[sql] def equalsIgnoreCompatibleCollation(from: DataType, to:
DataType): Boolean = {
(from, to) match {
// String types with possibly different collations are compatible.
- case (_: StringType, _: StringType) => true
+ case (a: StringType, b: StringType) => a.constraint == b.constraint
Review Comment:
Don't know if this made some tests fail, but could you add tests for alter
column with char/varchar to check what was behaviour before and after this
change, so we do not introduce behavioural change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
