stefankandic commented on code in PR #48663:
URL: https://github.com/apache/spark/pull/48663#discussion_r1849977110
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -565,11 +565,14 @@ case class StringToMap(text: Expression, pairDelim:
Expression, keyValueDelim: E
extends TernaryExpression with ExpectsInputTypes {
override def nullIntolerant: Boolean = true
def this(child: Expression, pairDelim: Expression) = {
- this(child, pairDelim, Literal(":"))
+ this(child, pairDelim, Literal.create(":", SQLConf.get.defaultStringType))
Review Comment:
I completely agree, however right now we don't have any logic in master
branch that determines default collation and we are just using session
collation. But I am addressing this in the other PR.
##########
sql/core/src/test/resources/sql-tests/analyzer-results/collations.sql.out:
##########
@@ -2332,14 +2332,9 @@ Project [left(collate(utf8_binary#x, utf8_lcase), 2) AS
left(collate(utf8_binary
-- !query
select rpad(utf8_binary, 8, utf8_lcase) from t5
Review Comment:
Yes, the output data type will always be of the `str` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
