cloud-fan commented on code in PR #48663:
URL: https://github.com/apache/spark/pull/48663#discussion_r1850298366


##########
sql/core/src/test/scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala:
##########
@@ -742,7 +742,7 @@ class CollationExpressionWalkerSuite extends SparkFunSuite 
with SharedSparkSessi
           }
         } catch {
           case e: SparkRuntimeException => assert(e.getCondition == 
"USER_RAISED_EXCEPTION")
-          case other: Throwable => throw other
+          case other: Throwable => throw new Exception(s"Query $query failed", 
other)

Review Comment:
   why is this change?



##########
sql/core/src/test/scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala:
##########
@@ -742,7 +742,7 @@ class CollationExpressionWalkerSuite extends SparkFunSuite 
with SharedSparkSessi
           }
         } catch {
           case e: SparkRuntimeException => assert(e.getCondition == 
"USER_RAISED_EXCEPTION")
-          case other: Throwable => throw other
+          case other: Throwable => throw new Exception(s"Query $query failed", 
other)

Review Comment:
   why is this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to