srielau commented on code in PR #48663: URL: https://github.com/apache/spark/pull/48663#discussion_r1850432958
########## sql/core/src/test/resources/sql-tests/analyzer-results/collations.sql.out: ########## @@ -2332,14 +2332,9 @@ Project [left(collate(utf8_binary#x, utf8_lcase), 2) AS left(collate(utf8_binary -- !query select rpad(utf8_binary, 8, utf8_lcase) from t5 Review Comment: Correct. We have one set of rules that apply to all functions and operators with no exceptions. So I think all the logic should fit into the "Least Common Type" algorithms. It should be a very narrow waist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
