harshmotw-db commented on code in PR #49080:
URL: https://github.com/apache/spark/pull/49080#discussion_r1872189189


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -96,6 +96,13 @@ trait CheckAnalysis extends PredicateHelper with 
LookupCatalog with QueryErrorsB
     case _ => None
   }
 
+  protected def variantExprInPartitionExpression(plan: LogicalPlan): 
Option[Expression] =

Review Comment:
   Repartition by map is currently allowed. I don't know whether that is 
intended. [My previous PR](https://github.com/apache/spark/pull/48909) which 
blocked set operations on Variant followed the same pattern as Maps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to